[Mesa-dev] [Bug 29684] [glsl] wine shaders break with mesa GLSL

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29684

--- Comment #8 from Kenneth Graunke <kenneth at whitecape.org> 2010-08-21 15:40:25 PDT ---
(In reply to comment #6)
> For what it's worth, this happens because of the array parameter in the
> function declaration "void order_ps_input(in vec4 OUT[12])" being mishandled by
> the GLSL compiler, as mentioned earlier on IRC to Eric and Ian. "void
> order_ps_input(in vec4[12] OUT)" does work as expected. That's also an easy
> workaround if you don't mind patching Wine source.

Thanks, Henri - good catch!  I've added piglit tests array-19.vert,
array-20.vert, and array-21.vert to test this, and fixed them in:

commit e511a35fc53fb75a2401d8a94c0c35634175c575
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sat Aug 21 15:30:34 2010 -0700

    glsl: Handle array declarations in function parameters.

    The 'vec4[12] foo' style already worked, but the 'vec4 foo[12]' style
    did not.  Also, 'vec4[] foo' was wrongly accepted.

    Fixes piglit test cases array-19.vert and array-21.vert.

    May fix fd.o bug #29684 (or at least part of it).

I haven't tested with wine, though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.