[Mesa-dev] r600g: various fixes to get r600_clear and depthtesting working

[Marek Olšák]

On Tue, May 25, 2010 at 9:51 AM, Jerome Glisse <glisse at freedesktop.org>wrote:

> On Tue, May 25, 2010 at 12:35:45AM +0200, Bas Nieuwenhuizen wrote:
> > Hello,
> >
> > I wrote two patches that fix various things to get r600g running on my
> > computer and to get r600_clear and depthtesting working.
> >
> > I wrote them starting from Marek's r600g branch.
> >
> > Feel free to criticize as this is my first contribution to a large
> > project.
> >
> > - Bas Nieuwenhuizen
> >
> > patches:
> > http://www.basnieuwenhuizen.nl/0001-r600g-various-fixes.patch
>
> I don't think change to r600_texture_destroy is right, why did you
> remove the unreference there ?
>

pipe_resource_reference calls resource_destroy (that is r600_texture_destroy
here) if the reference counter is zero. Using pipe_resource_reference in the
destroy function itself seems rather pointless and I think it's even
undefined.

-Marek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100525/7d6d0aa2/attachment.htm>