[Mesa-dev] [PATCH 1/2] _meta_GenerateMipmap: Set MaxLevel before allocating level

Will Dyson will.dyson at gmail.com
Fri May 28 10:35:46 PDT 2010


The radeon driver will fail to allocate miptree space for a new level
that is outside of BaseLevel..MaxLevel. Then it fails later, trying to
migrate the level to a miptree. Set MaxLevel to dstLevel before
allocating the level, and avoid triggering the problem.

Signed-off-by: Will Dyson <will.dyson at gmail.com>
---
 src/mesa/drivers/common/meta.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
index fc28685..3525583 100644
--- a/src/mesa/drivers/common/meta.c
+++ b/src/mesa/drivers/common/meta.c
@@ -2400,6 +2400,9 @@ _mesa_meta_GenerateMipmap(GLcontext *ctx, GLenum target,
          break;
       }
 
+      /* Set MaxLevel large enough to hold the new level when we allocate it  */
+      _mesa_TexParameteri(target, GL_TEXTURE_MAX_LEVEL, dstLevel);
+
       /* Create empty dest image */
       if (target == GL_TEXTURE_1D) {
          _mesa_TexImage1D(target, dstLevel, srcImage->InternalFormat,
-- 
1.7.1



More information about the mesa-dev mailing list