[Mesa-dev] [PATCH] main: remove duplicated includes

[Kenneth Graunke]

On 04/25/2011 09:37 AM, Nicolas Kaiser wrote:
> Remove duplicated includes of guarded headers.
>
> Signed-off-by: Nicolas Kaiser<nikai at nikai.net>
> ---
>   src/mesa/main/pack.c     |    1 -
>   src/mesa/main/texstore.c |    1 -
>   2 files changed, 0 insertions(+), 2 deletions(-)

What's the point?

The only justification I've ever heard is for (theoretically) speeding 
up build times (by some non-measurable amount).  This is really only 
interesting if you're continually compiling Mesa (for development or 
nightly builds for testing).  But if you're doing that, use ccache, as 
it'll make the build go orders of magnitude faster (by not actually 
bothering with the work).

For those of us who build with ccache, patches like this cause a 
pointless rebuild, actually making us spend -more- time compiling.

--Kenneth

> diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c
> index 4bb0a90..ad8ab9d 100644
> --- a/src/mesa/main/pack.c
> +++ b/src/mesa/main/pack.c
> @@ -37,7 +37,6 @@
>   #include "mtypes.h"
>   #include "pack.h"
>   #include "pixeltransfer.h"
> -#include "imports.h"
>
>
>   /**
> diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c
> index cf12241..c4fe82a 100644
> --- a/src/mesa/main/texstore.c
> +++ b/src/mesa/main/texstore.c
> @@ -63,7 +63,6 @@
>   #include "pack.h"
>   #include "pbo.h"
>   #include "imports.h"
> -#include "pack.h"
>   #include "texcompress.h"
>   #include "texcompress_fxt1.h"
>   #include "texcompress_rgtc.h"