[Mesa-dev] [PATCH] main: remove duplicated includes

Brian Paul brianp at vmware.com
Mon Apr 25 10:02:41 PDT 2011


On 04/25/2011 10:47 AM, Kenneth Graunke wrote:
> On 04/25/2011 09:37 AM, Nicolas Kaiser wrote:
>> Remove duplicated includes of guarded headers.
>>
>> Signed-off-by: Nicolas Kaiser<nikai at nikai.net>
>> ---
>> src/mesa/main/pack.c | 1 -
>> src/mesa/main/texstore.c | 1 -
>> 2 files changed, 0 insertions(+), 2 deletions(-)
>
> What's the point?
>
> The only justification I've ever heard is for (theoretically) speeding
> up build times (by some non-measurable amount). This is really only
> interesting if you're continually compiling Mesa (for development or
> nightly builds for testing). But if you're doing that, use ccache, as
> it'll make the build go orders of magnitude faster (by not actually
> bothering with the work).
>
> For those of us who build with ccache, patches like this cause a
> pointless rebuild, actually making us spend -more- time compiling.

I like to see sloppiness cleaned up.  I'll commit this soon.

-Brian


More information about the mesa-dev mailing list