[Mesa-dev] [PATCH] main: remove duplicated includes

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/25/2011 09:47 AM, Kenneth Graunke wrote:
> On 04/25/2011 09:37 AM, Nicolas Kaiser wrote:
>> Remove duplicated includes of guarded headers.
>>
>> Signed-off-by: Nicolas Kaiser<nikai at nikai.net>
>> ---
>>   src/mesa/main/pack.c     |    1 -
>>   src/mesa/main/texstore.c |    1 -
>>   2 files changed, 0 insertions(+), 2 deletions(-)
> 
> What's the point?
> 
> The only justification I've ever heard is for (theoretically) speeding
> up build times (by some non-measurable amount).  This is really only
> interesting if you're continually compiling Mesa (for development or
> nightly builds for testing).  But if you're doing that, use ccache, as
> it'll make the build go orders of magnitude faster (by not actually
> bothering with the work).
> 
> For those of us who build with ccache, patches like this cause a
> pointless rebuild, actually making us spend -more- time compiling.

We've also encountered a number of cases over the years where patches
like this BREAK the build for some configurations.

NAK.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk217UsACgkQX1gOwKyEAw+E4ACcCeqs0B77g5KPhkVzG0I8KmDS
4X4An3sZUUUalW0AZCbrGz/SiPUS5MKR
=ufZO
-----END PGP SIGNATURE-----