[Mesa-dev] [PATCH 1/3] mesa: Add ARB_shader_texture_lod to the extension list; off by default.

Ian Romanick idr at freedesktop.org
Mon Apr 25 15:03:08 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/22/2011 12:02 PM, Kenneth Graunke wrote:
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/main/extensions.c |    2 +-
>  src/mesa/main/mtypes.h     |    1 +
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index 8a0ab96..fc55184 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -111,6 +111,7 @@ static const struct extension extension_table[] = {
>     { "GL_ARB_seamless_cube_map",                   o(ARB_seamless_cube_map),                   GL,             2009 },
>     { "GL_ARB_shader_objects",                      o(ARB_shader_objects),                      GL,             2002 },
>     { "GL_ARB_shader_stencil_export",               o(ARB_shader_stencil_export),               GL,             2009 },
> +   { "GL_ARB_shader_texture_lod",                  o(ARB_shader_texture_lod),                  GL,             2009 },
>     { "GL_ARB_shading_language_100",                o(ARB_shading_language_100),                GL,             2003 },
>     { "GL_ARB_shadow_ambient",                      o(ARB_shadow_ambient),                      GL,             2001 },
>     { "GL_ARB_shadow",                              o(ARB_shadow),                              GL,             2001 },
> @@ -142,7 +143,6 @@ static const struct extension extension_table[] = {
>     { "GL_ARB_vertex_shader",                       o(ARB_vertex_shader),                       GL,             2002 },
>     { "GL_ARB_vertex_type_2_10_10_10_rev",          o(ARB_vertex_type_2_10_10_10_rev),          GL,             2009 },
>     { "GL_ARB_window_pos",                          o(ARB_window_pos),                          GL,             2001 },
> -
>     /* EXT extensions */
>     { "GL_EXT_abgr",                                o(EXT_abgr),                                GL,             1995 },
>     { "GL_EXT_bgra",                                o(EXT_bgra),                                GL,             1995 },

Please leave the blank line.  There should be another one after the EXT
instructions before the vendor extensions.  It makes it a bit easier to
scan the (very long) list.

> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 160ae9d..6e4c4f1 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -2781,6 +2781,7 @@ struct gl_extensions
>     GLboolean ARB_seamless_cube_map;
>     GLboolean ARB_shader_objects;
>     GLboolean ARB_shader_stencil_export;
> +   GLboolean ARB_shader_texture_lod;
>     GLboolean ARB_shading_language_100;
>     GLboolean ARB_shadow;
>     GLboolean ARB_shadow_ambient;

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk2175wACgkQX1gOwKyEAw/t8QCfReG4W3HaZ2vosDD519JL6Hmi
TkcAnR4QN7JLFB3973WkqI0B+58W5P26
=3oPf
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list