[Mesa-dev] [PATCH 1/3] mesa: Add ARB_shader_texture_lod to the extension list; off by default.

Kenneth Graunke kenneth at whitecape.org
Mon Apr 25 22:26:20 PDT 2011


On 04/25/2011 03:03 PM, Ian Romanick wrote:
>> @@ -142,7 +143,6 @@ static const struct extension extension_table[] = {
>>      { "GL_ARB_vertex_shader",                       o(ARB_vertex_shader),                       GL,             2002 },
>>      { "GL_ARB_vertex_type_2_10_10_10_rev",          o(ARB_vertex_type_2_10_10_10_rev),          GL,             2009 },
>>      { "GL_ARB_window_pos",                          o(ARB_window_pos),                          GL,             2001 },
>> -
>>      /* EXT extensions */
>>      { "GL_EXT_abgr",                                o(EXT_abgr),                                GL,             1995 },
>>      { "GL_EXT_bgra",                                o(EXT_bgra),                                GL,             1995 },
>
> Please leave the blank line.  There should be another one after the EXT
> instructions before the vendor extensions.  It makes it a bit easier to
> scan the (very long) list.

Of course.  I had merge conflicts with the addition of the dates and 
accidentally removed it while resolving those.  Thanks.


More information about the mesa-dev mailing list