[Mesa-dev] [PATCH 4/7] ir_to_mesa: Use Add linker_error_printf instead of fail_link

Kenneth Graunke kenneth at whitecape.org
Mon Aug 1 23:28:39 PDT 2011

On 08/01/2011 10:20 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> The functions were almost identical.
> ---
>  src/mesa/program/ir_to_mesa.cpp |   56 +++++++++++++++++---------------------
>  1 files changed, 25 insertions(+), 31 deletions(-)

I might go ahead and call these linker_error and linker_warning.  I
don't usually expect "printf" functions to set error flags, but I
-would- expect "error" functions to do so.  Plus, they're shorter names.

But either way, seems like a good idea.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

More information about the mesa-dev mailing list