[Mesa-dev] Mesa (master): egl/gbm: Fix EGL_DEFAULT_DISPLAY

[Chad Versace]

On 08/05/2011 12:30 AM, Benjamin Franzke wrote:
> 2011/8/5 Chad Versace <chad at chad-versace.us>:
>> This commit *really* needs a more descriptive commit message.
> 
> Ok, I thought its clear what is to be done for EGL_DEFAULT_DISPLAY.
> But your right, it should have more descriptive. In future I'll try to do so.
> 
> Since I cant change the commit message now, let me answer your questions.
> 
>>  - What were the symptoms of the broken EGL_DEFAULT_DISPLAY?
> 
> Segfault, because the native egl display is NULL.
> 
>>  - What error in the code caused the problem?
> 
> Not handling the above.
> 
>>  - What the hell did you do to fix it? This is not evident due to the length
>>    of the commit.
> 
> Well, its really just creating a new gbm device if there is none given,
> and properly destroying it, if created by ourself.
> 
> And what does this fix?
> eglinfo.c in mesa/demos/src/egl/opengl/ with EGL_PLATFORM=drm
> 
> P.S. This has nothing to do with hell.
> I understand that bad commit messages can upset, but lets keep patient.

Apologies, Ben. I let the moment's emotion get the better of me. Thanks for the
taking the time to explain the commit.

-- 
Chad Versace
chad at chad-versace.us

> 
>> For commits of this complexity, write descriptive messages for the sake of others.
>>
>> --
>> Chad Versace
>> chad at chad-versace.us