[Mesa-dev] [PATCH 4/4] glsl: Check array size is const before asserting that no IR was generated.

Kenneth Graunke kenneth at whitecape.org
Fri Aug 5 18:22:53 PDT 2011

On 08/01/2011 04:07 PM, Paul Berry wrote:
> process_array_type() contains an assertion to verify that no IR
> instructions are generated while processing the expression that
> specifies the size of the array.  This assertion needs to happen
> _after_ checking whether the expression is constant.  Otherwise we may
> crash on an illegal shader rather than reporting an error.
> Fixes piglit tests array-size-non-builtin-function.vert and
> array-size-with-side-effect.vert.

Good catch.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

More information about the mesa-dev mailing list