[Mesa-dev] [PATCH] glsl: Implement the GL_ARB_conservative_depth extension.

[Kenneth Graunke]

On 08/09/2011 03:33 PM, Ian Romanick wrote:
> On 08/09/2011 10:59 AM, Kenneth Graunke wrote:
>> It's the same as GL_AMD_conservative_depth.  The specs have slight
>> differences in wording, but don't differ in content or behavior.
> 
>> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> Why do you add ARB_conservative_depth_{enable,warn} flags to
> _mesa_glsl_parse_state but not use them?

They are used, just non-obviously.  The EXT macro call below uses them:

>> diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp
>> index cc78137..8f740e6 100644
>> --- a/src/glsl/glsl_parser_extras.cpp
>> +++ b/src/glsl/glsl_parser_extras.cpp
>> @@ -253,6 +253,7 @@ struct _mesa_glsl_extension {
>>  static const _mesa_glsl_extension _mesa_glsl_supported_extensions[] = {
>>     /*                                  target availability  API availability */
>>     /* name                             VS     GS     FS     GL     ES         supported flag */
>> +   EXT(ARB_conservative_depth,         true,  false, true,  true,  false,     AMD_conservative_depth),
>>     EXT(ARB_draw_buffers,               false, false, true,  true,  false,     dummy_true),
>>     EXT(ARB_draw_instanced,             true,  false, false, true,  false,     ARB_draw_instanced),
>>     EXT(ARB_explicit_attrib_location,   true,  false, true,  true,  false,     ARB_explicit_attrib_location),