[Mesa-dev] [PATCH] mesa: Do not include fpu_control.h

Chad Versace chad at chad-versace.us
Mon Aug 15 16:54:40 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/15/2011 01:58 PM, Brian Paul wrote:
> On 08/15/2011 02:54 PM, Eric Anholt wrote:
>> On Mon, 15 Aug 2011 11:26:51 -0700, Chad Versace<chad at chad-versace.us>
>> wrote:
>>> Remove the inclusion of fpu_control.h from compiler.h.  Since compiler.h 
>>> uses no symbol from fpu_control.h, the removal is safe.
>>> 
>>> Since Bionic lacks fpu_control.h, its inclusion breaks the Android
>>> build.
>> 
>> I think this means that the one use of fpu_control.h in debug.c will never
>> trigger any more.  I suspect it's Brian's code, and if he wants to keep it,
>> we should put this under an autoconf-detected HAVE_FPU_CONTROL_H #define.
>> fpu_control.h is breaking my 32-bit builds because the header isn't present
>> in the cross environment apparently, and I've never used that debug code so
>> I'm not really interested in keeping it, myself.
> 
> I haven't used that code in years so I have no problem with removing it.
> 
> -Brian

I've posted a new patch that removes the debug bits too.

According to `grep -ri fpu_`, that was the sole use of fpu_control.h.

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOSbHAAAoJEAIvNt057x8iwvMP/35FMv5VnC9+DJewWRbCWIyM
CUkWTnME1UxcCmZJ/YI9GNfHV/Eiu7cNtRcJQXliNVLH52iGeBy7QnKd+MpkUPr1
P8nlRj4DeSlTAVKj5aNzle1WgFK+UqG7PpiedddSTQeoiyP0MDNsXuj6QtwZamLb
tGz8Ea78a/6SlFnXlEcukdKPLJ7YwITLCuUt1LRWEUSgA3lr3meoHjVDS4T0dlCC
G4XqnLi6bxdbJ3+9uCKDi/9w17hEg4PMiHzQ4g9YGvQ4s9I5wpXANqxUa0Dm3jFW
aA9RiVpjbr8vo3CCa/cDVrnGbBAnA7w6klf+NFy3eioRdCXEEV1VSuWJ5zEu9CYh
mQOycx5DNHTvqpA+aiyW+nhJNcl6mZrxv3dGUdrwVNigTs4O2v5x70nXlgEHH3JI
ZnbdYCT/nl0eXrnB1DDyH+VernM3Fnq/r7a7n4Tf5h5XzLjfX/os4Z9Skmk1pvZ4
RjxL6W8W5HKDiSisIcgV2Ka1nOrameDp7Ei2yCkqxWod/MbpsirFv6NluS4g9Eju
oi2k3074dAd8RNasLPAp5GNUNSLuDbRYkq+0uca1bq6ZX7IQ5mTqxf1vfaOEpbX8
ygZpSeNzQmDce5lTiUjsImuf2/pFZmSFIcj5DRuSDptKQ/QjpCH1LbQ3siRmS/+K
eTFRktLMsHqN5aY8DMDv
=wE1U
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list