[Mesa-dev] [PATCH 0/11] Post-processing infrastructure / gsoc work

[Lauri Kasanen]

On Tue, 16 Aug 2011 18:44:35 -0600
Brian Paul <brian.e.paul at gmail.com> wrote:

Hi

Thanks for taking the time to read them through. Patch 07 seems still stuck in the ML moderation queue.

> > The set builds on top of the three cleanup patches sent earlier; they haven't been applied to master, nor have gotten any comments.
> 
> Maybe you could re-post those?

Reposted.

> How exactly does the post-processing step interface to the gallium
> drivers?  I took a quick look but it didn't jump out at me.  Maybe you
> could also write a documentation page to add in the docs/ directory.

The PP queue is bound to the DRI context. It is init and shut down with the context, and called on swapbuffers (flush for dri2 hw drivers). EGL and other such systems can implement it similarly if desired.

> Otherwise, here's some stylistic things I noted:

I was told these weren't as strict for files under their own self-contained dir (aux/pp) vs changes to existing dirs (where I did take care to fit in).

> 2. The copyright notices reference Tungsten Graphics.  You should
> probably replace that with "the authors".

Will change, thanks.

Will do the other changes as well.

- Lauri