[Mesa-dev] [PATCH] st/mesa: fix incorrect loop over instruction src regs

[Bryan Cain]

The usual commit message prefix for changes to glsl_to_tgsi is
"glsl_to_tgsi", not "st/mesa".

On 08/16/2011 05:33 PM, Brian Paul wrote:
> The array of src regs is of size 3, not 4.
> ---
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index aef23e7..7b90c81 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -3443,7 +3443,7 @@ glsl_to_tgsi_visitor::eliminate_dead_code_advanced(void)
>           /* Continuing the block, clear any channels from the write array that
>            * are read by this instruction.
>            */
> -         for (int i = 0; i < 4; i++) {
> +         for (unsigned i = 0; i < Elements(inst->src); i++) {

Why not just use 3 here?

>              if (inst->src[i].file == PROGRAM_TEMPORARY && inst->src[i].reladdr){
>                 /* Any temporary might be read, so no dead code elimination 
>                  * across this instruction.

You're right that the change itself is needed, though.

Bryan