[Mesa-dev] [PATCH 09/18] android: build libGLES_mesa

[Chia-I Wu]

On Thu, Aug 18, 2011 at 10:14 PM, Chad Versace <chad at chad-versace.us> wrote:
[snip]
>>>>> +# The rules can be found in src/gallium/targets/Android.mk.
>> ---
>> This comment line is misleading. It implies that the build system is intended only for Gallium.
>> Very soon the build system will also build non-Gallium drivers.
>
>>> That is where libGLES_mesa is built even there is no Gallium driver.
>>> When Gallium drivers are enabled, a set of static libraries will be
>>> added to libGLES_mesa.  When non-Gallium drivers are enabled, another
>>> set of static libraries will be added to.
>>
>>> The most reasonable place for it would be src/egl/Android.mk.  But its
>>> contents will be mostly about Gallium (winsys, pipe drivers, state
>>> trackers, and etc.).  That is why it is in
>>> gallium/targets/egl-static/.  Do you prefer to move it or is it
>>> suffice if I add more comments to the top-level Android.mk?
>
> Let's not make the Intel drivers second-class citizens in the build system ;)
>
> The Intel drivers, their contents will *not* "be mostly about Gallium (winsys,
> pipe drivers, state trackers, and etc)". Having libGLES be built in a
> Gallium subdir, even when no Gallium drivers are being built, is *very* confusing.
> Building it in src/egl is also confusing, because src/egl should build libEGL,
> not libGLES.
>
> libGLES should be built in same directory as it is currently being built by the
> autoconf/Scons build, or it should be built at the toplevel. Also, the Gallium-
I will move the rules to the top-level Android.mk.
> specific directories (winsys, pipe drivers, state trackers, etc) should only be
> built when a Gallium driver is built.
Yeah, that is already the case.  A module is built only when needed.

It is late here.  I should be able to do v2 tomorrow.

-- 
olv at LunarG.com