[Mesa-dev] [PATCH 1/1] Fix minor inconsistency for new method try_emit_mad_for_and_not()

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/22/2011 03:10 AM, Kai Wasserbäch wrote:
> 
> Commits ff2cfb8989cd and 5379a70d3fab introduced
> try_emit_mad_for_and_not for ir_to_mesa and glsl_to_tgsi respectively.
> In both cases the methods had a return type of "bool" instead of
> "GLboolean".

In general we're trying to move away from GLboolean in places that
aren't part of the GL API (i.e., places where it's required).  See this
mailing list thread:

	http://marc.info/?l=mesa3d-dev&m=130754488901774&w=2

It it was a mistake use GLboolean in the other try_emit_* functions.
When I added try_emit_mad_for_and_not, I followed the "new" guidelines.

I would support a patch that changes the return type of the other
try_emit_* functions and adds some test to docs/devinfo.html about the
use of bool vs. GLboolean.

> Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
> ---
>  src/mesa/program/ir_to_mesa.cpp            |    4 ++--
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk5SiXMACgkQX1gOwKyEAw+pHACcCR6JwJJG+HXSOAKFLkoqgVqv
MEYAnR+o5hyRvgEq3uda0kksdWStIwNd
=sAyb
-----END PGP SIGNATURE-----