[Mesa-dev] [PATCH 1/8] android: Remove -fvisibility=hidden from CFLAGS so that we can build a shared dricore

[Chia-I Wu]

On Sat, Aug 27, 2011 at 9:53 AM, Chad Versace <chad at chad-versace.us> wrote:
> If you attempt to link together libmesa_dricore.so from object files built with
> visibility=hidden, then the library is useless. It exposes no symbols.
>
> Signed-off-by: Chad Versace <chad at chad-versace.us>
> ---
>  Android.common.mk |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/Android.common.mk b/Android.common.mk
> index 83177a0..6519cbf 100644
> --- a/Android.common.mk
> +++ b/Android.common.mk
> @@ -26,7 +26,6 @@ LOCAL_C_INCLUDES += \
>
>  LOCAL_CFLAGS += \
>        -DPTHREADS \
> -       -fvisibility=hidden \
>        -Wno-sign-compare
I think -fvisibility=hidden should be default on, but can be disabled
per module.  Adding

ifneq ($(strip $(MESA_NO_VISIBLITY_HIDDEN)),true)
LOCAL_CFLAGS += -fvisibility=hidden
endif
# clear the variable for the next module
MESA_NO_VISIBLITY_HIDDEN :=

should do.

libmesa_dricore will be built with MESA_NO_VISIBLITY_HIDDEN := true.
If symbols from libmesa_glsl are referenced by DRI drivers, you also
need to add libmesa_glsl_for_dricore to src/glsl/Android.mk.

>  ifeq ($(strip $(MESA_ENABLE_ASM)),true)
> --
> 1.7.6
>
>



-- 
olv at LunarG.com