[Mesa-dev] [PATCH 3/3] xorg/xvmc: Add missing call to set_picture_parameters

Christian König deathsimple at vodafone.de
Sun Aug 28 08:04:06 PDT 2011


Hi Maarten,

could you put this into SetDecoderStatus instead? This makes the picture
structure also available in end_frame.

Also named initializers shouldn't be used according to the coding rules.

Christian.

Am Sonntag, den 28.08.2011, 01:59 +0200 schrieb Maarten Lankhorst:
> picture_structure is needed to determine what type of picture this is
> 
> Signed-off-by: Maarten Lankhorst <m.b.lankhorst at gmail.com>
> ---
>  src/gallium/state_trackers/xorg/xvmc/surface.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/gallium/state_trackers/xorg/xvmc/surface.c b/src/gallium/state_trackers/xorg/xvmc/surface.c
> index 9cfec94..552cd5d 100644
> --- a/src/gallium/state_trackers/xorg/xvmc/surface.c
> +++ b/src/gallium/state_trackers/xorg/xvmc/surface.c
> @@ -215,6 +215,7 @@ Status XvMCRenderSurface(Display *dpy, XvMCContext *context, unsigned int pictur
>  {
>     struct pipe_mpeg12_macroblock mb[num_macroblocks];
>     struct pipe_video_decoder *decoder;
> +   struct pipe_mpeg12_picture_desc desc = { { PIPE_VIDEO_PROFILE_MPEG1}, .picture_structure = picture_structure };
>  
>     XvMCContextPrivate *context_priv;
>     XvMCSurfacePrivate *target_surface_priv;
> @@ -286,6 +287,7 @@ Status XvMCRenderSurface(Display *dpy, XvMCContext *context, unsigned int pictur
>     target_surface_priv->ref[1] = future_surface;
>  
>     SetDecoderStatus(target_surface_priv);
> +   context_priv->decoder->set_picture_parameters(context_priv->decoder, &desc.base);
>  
>     if (!target_surface_priv->frame_started) {
>        target_surface_priv->frame_started = 1;




More information about the mesa-dev mailing list