[Mesa-dev] [PATCH 8/8] i965: Build i965_dri.so for Android

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/26/2011 10:51 PM, Chia-I Wu wrote:
> On Sat, Aug 27, 2011 at 9:54 AM, Chad Versace <chad at chad-versace.us> wrote:
>> This just gets the driver to build. I have not yet tested if the driver
>> actually works.
>>
>> Signed-off-by: Chad Versace <chad at chad-versace.us>
>> ---
>>  Android.mk                           |    3 +-
>>  src/mesa/drivers/dri/Android.mk      |   61 ++++++++++++++++++++++++++++++++++
>>  src/mesa/drivers/dri/i965/Android.mk |   61 ++++++++++++++++++++++++++++++++++
>>  3 files changed, 124 insertions(+), 1 deletions(-)
>>  create mode 100644 src/mesa/drivers/dri/Android.mk
>>  create mode 100644 src/mesa/drivers/dri/i965/Android.mk
>>
>> diff --git a/Android.mk b/Android.mk
>> index ab1778e..e9711ba 100644
>> --- a/Android.mk
>> +++ b/Android.mk
>> @@ -35,7 +35,7 @@ MESA_PYTHON2 := python
>>  DRM_TOP := external/drm
>>  DRM_GRALLOC_TOP := hardware/drm_gralloc
>>
>> -classic_drivers :=
>> +classic_drivers := i965
> Please also update the comments at the top.  BTW, I am fine replacing
> all classic/CLASSIC by dri/DRI if that is preferred.

I'll update the comment.

I think we should rename CLASSIC to DRI too, but we can do that after
these patches land.

> 
>>  gallium_drivers := swrast r600g
>>
>>  MESA_GPU_DRIVERS := $(BOARD_GPU_DRIVERS)
>> @@ -74,6 +74,7 @@ SUBDIRS := \
>>        src/mapi \
>>        src/glsl \
>>        src/mesa \
>> +       src/mesa/drivers/dri \
>>        src/mesa/drivers/dri/common \
>>        src/egl/main
> The directory should be added only when MESA_BUILD_CLASSIC is true.
> 
> Is it cleaner to remove src/mesa/drivers/dri/common from here and let
> src/mesa/drivers/dri/Android.mk handle it?  So it will be the
> Android.mk in charge of DRI drivers, similar to the role of
> src/gallium/Android.mk.

Agreed. I'll fix that in v2.

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOWmgnAAoJEAIvNt057x8i2BIP/27srdBNDGUDxutA0tDbBwoi
PUxxKn63G1NHBfxoe+NeI+3RmLeF/5M0+FP6+k3Y5GYajsKDz+MAXwNsLi5ji6MF
ka4bFJYPeEDhmjn+9I2rR0bQICoUOYneVFm83tv8l0ZbwMGGJyg2ZxafN4GZbNEZ
g22Cs9zWfP9D/3qLHkPmSVOrYup2ri1XSniTXTuZOcylRaIEmj5DRxDMnCFBQj7B
ZxJ18mC31EqqGxvFrozqd3tcsbuV/dZ5P6yV0HXnI4lyZeopF7iYn9dvK7yDDvH3
Xk/frOnR9LwHJ0dflULD0SsQCRjKgcKbdD7Q16d4fVVj06U0krKjkjUUw31eYbnw
uFMQTCzjmVngebc+RM6wfHyEUJ15qCtuujchi01d1Tbk8Bls6lzrsZeDSCTPxAJb
1XpbHszON2JIs3iGKVeyYbF9hvUUauFKR+fDZcNfOSaYm2tijI+/3+JH9XMxBo6U
3Kjlh6KRNWxTgbC4PdSjyFRaeZwHugWs2LkYC6EAD46yYECh63rp8xmu1E2+icc/
NaAoY2DTXfCXIhxtrdh0D2DCcttSZL02oKsdAvWcE9aqUNjn5RLP6zmlf8BBsgWY
fDXi1L40yR45XFmpujdjNzROif96Do8HPjzD2SqHYBoLG7BZAd9dn81TgXcPdPwQ
3Twqm8MeJUdV/5s1aaTK
=yX3O
-----END PGP SIGNATURE-----