[Mesa-dev] [PATCH 02/20] glsl: Silence "ast_to_hir.cpp:1984:25: warning: comparison of unsigned expression >= 0 is always true"

Kenneth Graunke kenneth at whitecape.org
Mon Aug 29 23:09:49 PDT 2011


On 08/29/2011 02:58 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> ast_type_qualifier::location should have been a signed integer from
> the beginning, and the giant comment in
> apply_type_qualifier_to_variable explains why.
> ---
>  src/glsl/ast.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/glsl/ast.h b/src/glsl/ast.h
> index d1de227..532347d 100644
> --- a/src/glsl/ast.h
> +++ b/src/glsl/ast.h
> @@ -372,7 +372,7 @@ struct ast_type_qualifier {
>      * \note
>      * This field is only valid if \c explicit_location is set.
>      */
> -   unsigned location;
> +   int location;
>  
>     /**
>      * Return true if and only if an interpolation qualifier is present.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40207
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list