[Mesa-dev] [PATCH] mesa: handle zero-size buffers in MapBuffer and ranges in MapBufferRange

Marek Olšák maraeo at gmail.com
Tue Aug 30 13:02:24 PDT 2011


Alright, I'll send a new patch.

Marek

On Tue, Aug 30, 2011 at 9:55 PM, Brian Paul <brian.e.paul at gmail.com> wrote:
> On Tue, Aug 30, 2011 at 12:54 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 08/30/2011 10:15 AM, Marek Olšák wrote:
>>> Moved from st/mesa.
>>> This also fixes an assertion failure in piglit/fdo31934 on gallium drivers.
>>
>> So... I guess I don't understand why the mapping can't just fail and set
>> GL_OUT_OF_MEMORY.  Returning a pointer to some random bit of storage
>> seems like a recipe for bugs that are excruciating for app developers to
>> debug.
>
> Looks like NVIDIA generates GL_OUT_OF_MEMORY and returns NULL.
> I'd prefer that to the dummy buffer.
>
> -Brian
>


More information about the mesa-dev mailing list