[Mesa-dev] [PATCH 1/2] intel: Remove the passthrough TexSubImage[13]D functions.

Ian Romanick idr at freedesktop.org
Tue Aug 30 13:42:43 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/30/2011 10:37 AM, Eric Anholt wrote:
> All we need for these is _mesa_store_texsubimage[13]d(), since we
> don't do the blit path.

For the series:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Tested-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>  src/mesa/drivers/dri/intel/intel_tex_subimage.c |   42 -----------------------
>  1 files changed, 0 insertions(+), 42 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/intel/intel_tex_subimage.c b/src/mesa/drivers/dri/intel/intel_tex_subimage.c
> index 49c8ae9..851b09e 100644
> --- a/src/mesa/drivers/dri/intel/intel_tex_subimage.c
> +++ b/src/mesa/drivers/dri/intel/intel_tex_subimage.c
> @@ -148,27 +148,6 @@ intelTexSubimage(struct gl_context * ctx,
>  			     packing, texObj, texImage);
>  }
>  
> -
> -static void
> -intelTexSubImage3D(struct gl_context * ctx,
> -                   GLenum target,
> -                   GLint level,
> -                   GLint xoffset, GLint yoffset, GLint zoffset,
> -                   GLsizei width, GLsizei height, GLsizei depth,
> -                   GLenum format, GLenum type,
> -                   const GLvoid * pixels,
> -                   const struct gl_pixelstore_attrib *packing,
> -                   struct gl_texture_object *texObj,
> -                   struct gl_texture_image *texImage)
> -{
> -   intelTexSubimage(ctx, 3,
> -                    target, level,
> -                    xoffset, yoffset, zoffset,
> -                    width, height, depth, 0,
> -                    format, type, pixels, packing, texObj, texImage);
> -}
> -
> -
>  static void
>  intelTexSubImage2D(struct gl_context * ctx,
>                     GLenum target,
> @@ -189,29 +168,8 @@ intelTexSubImage2D(struct gl_context * ctx,
>  }
>  
>  
> -static void
> -intelTexSubImage1D(struct gl_context * ctx,
> -                   GLenum target,
> -                   GLint level,
> -                   GLint xoffset,
> -                   GLsizei width,
> -                   GLenum format, GLenum type,
> -                   const GLvoid * pixels,
> -                   const struct gl_pixelstore_attrib *packing,
> -                   struct gl_texture_object *texObj,
> -                   struct gl_texture_image *texImage)
> -{
> -   intelTexSubimage(ctx, 1,
> -                    target, level,
> -                    xoffset, 0, 0,
> -                    width, 1, 1, 0,
> -                    format, type, pixels, packing, texObj, texImage);
> -}
> -
>  void
>  intelInitTextureSubImageFuncs(struct dd_function_table *functions)
>  {
> -   functions->TexSubImage1D = intelTexSubImage1D;
>     functions->TexSubImage2D = intelTexSubImage2D;
> -   functions->TexSubImage3D = intelTexSubImage3D;
>  }

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk5dS0MACgkQX1gOwKyEAw/GyACgh35dh0DHz/hVvtTkI5ruC3kJ
afIAn3GcPB0Fx6sNU2DS1tYOvSx77aFC
=N3qb
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list