[Mesa-dev] [PATCH 1/3] i965/vs: Fix incorrect subscript when resetting copy propagation records.

[Christopher James Halse Rogers]

On Fri, 2011-12-23 at 20:57 -0800, Kenneth Graunke wrote:
> In this code, 'i' loops over the number of virtual GRFs, while 'j' loops
> over the number of vector components (0 <= j <= 3).
> 
> It can't possibly be correct to see if bit 'i' is set in the destination
> writemask, as it will have values much larger than 3.  Clearly this is
> supposed to be 'j'.
> 
> Found by inspection.
> 
> Cc: Eric Anholt <eric at anholt.net>
> Cc: Matt Turner <mattst88 at gmail.com>
> Cc: Christopher James Halse Rogers <chalserogers at gmail.com>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  .../drivers/dri/i965/brw_vec4_copy_propagation.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Matt and Christopher,
> 
> Could you test Counter Strike and Civ V with this patch series?
> I think it should solve your regressions with the new VS backend.

Works a treat.

For the series:
Tested-by: Christopher James Halse Rogers
<christopher.halse.rogers at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111224/3fa21a8d/attachment-0001.pgp>