[Mesa-dev] [PATCH 1/3] i965/vs: Fix incorrect subscript when resetting copy propagation records.

[Eric Anholt]

On Fri, 23 Dec 2011 20:57:46 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> In this code, 'i' loops over the number of virtual GRFs, while 'j' loops
> over the number of vector components (0 <= j <= 3).
> 
> It can't possibly be correct to see if bit 'i' is set in the destination
> writemask, as it will have values much larger than 3.  Clearly this is
> supposed to be 'j'.
> 
> Found by inspection.

Yeah, making a runtime test for this one would suck.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111227/cab58399/attachment.pgp>