[Mesa-dev] [PATCH] gallium: new transfer flag: DISCARD_WHOLE_RESOURCE

José Fonseca jfonseca at vmware.com
Fri Feb 18 08:54:50 PST 2011


On Fri, 2011-02-18 at 08:38 -0800, Brian Paul wrote:
> On 02/18/2011 09:15 AM, jfonseca at vmware.com wrote:
> > From: Keith Whitwell<keithw at vmware.com>
> >
> > ---
> >   src/gallium/include/pipe/p_defines.h |   19 +++++++++++++++++--
> >   1 files changed, 17 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> > index f66bbaf..2de707f 100644
> > --- a/src/gallium/include/pipe/p_defines.h
> > +++ b/src/gallium/include/pipe/p_defines.h
> > @@ -229,9 +229,9 @@ enum pipe_transfer_usage {
> >       *
> >       * See also:
> >       * - OpenGL's ARB_map_buffer_range extension, MAP_INVALIDATE_RANGE_BIT flag.
> > -    * - Direct3D's D3DLOCK_DISCARD flag.
> >       */
> >      PIPE_TRANSFER_DISCARD = (1<<  8),
> > +   PIPE_TRANSFER_DISCARD_RANGE = (1<<  8),
> 
> Does the second flag replace the first one?  Are we keeping the first 
> one just as a transitory thing?  I'd say to either remove the old one 
> or add a comment explaining what's going on.

It's a transitory thing. I'll add a /* DEPRECATED */ comment and then
start renaming.

Jose



More information about the mesa-dev mailing list