[Mesa-dev] [Bug 34455] New: sed in mesa Makefile: expanded PC_LIB_PRIV might contain comma

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34455

           Summary: sed in mesa Makefile: expanded PC_LIB_PRIV might
                    contain comma
           Product: Mesa
           Version: 7.10
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Other
        AssignedTo: mesa-dev at lists.freedesktop.org
        ReportedBy: dilyan.palauzov at aegee.org


In Mesa-7.10.0, src/mesa/Makefile contains

osmesa_pcedit = sed \
        $(pcedit) \
        -e 's, at OSMESA_LIB@,$(OSMESA_LIB),' \
        -e 's, at OSMESA_PC_REQ@,$(OSMESA_PC_REQ),' \
        -e 's, at OSMESA_PC_LIB_PRIV@,$(OSMESA_PC_LIB_PRIV),'

In my case:

OSMESA_PC_LIB_PRIV is expanded to -lm -lpthread  -ldl -Wl,-rpath,/usr/lib64
-L/usr/lib64 -ltalloc

which leads to the sed expression:

sed ... -e 's, at OSMESA_PC_LIB_PRIV@,-lm -lpthread  -ldl -Wl,-rpath,/usr/lib64
-L/usr/lib64 -ltalloc  ,' osmesa.pc.in > osmesa.pc

This sed expression has unforeseen commas and is therefore invalid.

I suggest replacing the comma in the Makefile with some other symbol, e.g. %

The same applies for the generation of src/mesa/gl.pc,  which produces -e
's, at GL_PC_LIB_PRIV@,-lm -lpthread -Wl,-rpath,/usr/lib64 -L/usr/lib64 -ltalloc 
,'.

The same applies for the generation of ./src/egl/main/egl.pc .

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.