[Mesa-dev] [PATCH 2/2] mesa: Add/remove extensions in extension string

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/09/2011 11:23 PM, Chad Versace wrote:
> Add GL_OES_stencil8 to ES2.
> 
> Remove the following:
> GL_OES_compressed_paletted_texture : ES1
> GL_OES_depth32                     : ES1, ES2
> GL_OES_stencil1                    : ES1, ES2
> GL_OES_stencil4                    : ES1, ES2
> ---
>  src/mesa/main/extensions.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index f0d257a..f084516 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -218,9 +218,9 @@ static const struct extension extension_table[] = {
>     { "GL_OES_blend_func_separate",                 o(EXT_blend_func_separate),                      ES1       },
>     { "GL_OES_blend_subtract",                      o(EXT_blend_subtract),                           ES1       },
>     { "GL_OES_byte_coordinates",                    o(dummy_true),                                   ES1       },
> -   { "GL_OES_compressed_paletted_texture",         o(dummy_true),                                   ES1       },
> +   { "GL_OES_compressed_paletted_texture",         o(dummy_true),                              0              },

I think instead of 0, we should use a macro DISABLE_IN_ALL_APIs or
similar.  I was completely misunderstanding what was happening, so I had
written this long e-mail describing why all of these extensions should
be selectively enabled by drivers. :)

>     { "GL_OES_depth24",                             o(ARB_framebuffer_object),                       ES1 | ES2 },
> -   { "GL_OES_depth32",                             o(ARB_framebuffer_object),                       ES1 | ES2 },
> +   { "GL_OES_depth32",                             o(ARB_framebuffer_object),                  0              },
>     { "GL_OES_depth_texture",                       o(ARB_depth_texture),                                  ES2 },
>  #if FEATURE_OES_draw_texture
>     { "GL_OES_draw_texture",                        o(OES_draw_texture),                             ES1 | ES2 },
> @@ -243,9 +243,9 @@ static const struct extension extension_table[] = {
>     { "GL_OES_rgb8_rgba8",                          o(ARB_framebuffer_object),                       ES1 | ES2 },
>     { "GL_OES_single_precision",                    o(dummy_true),                                   ES1       },
>     { "GL_OES_standard_derivatives",                o(ARB_fragment_shader),                                ES2 },
> -   { "GL_OES_stencil1",                            o(ARB_framebuffer_object),                       ES1 | ES2 },
> -   { "GL_OES_stencil4",                            o(ARB_framebuffer_object),                       ES1 | ES2 },
> -   { "GL_OES_stencil8",                            o(ARB_framebuffer_object),                       ES1       },
> +   { "GL_OES_stencil1",                            o(ARB_framebuffer_object),                  0              },
> +   { "GL_OES_stencil4",                            o(ARB_framebuffer_object),                  0              },
> +   { "GL_OES_stencil8",                            o(ARB_framebuffer_object),                       ES1 | ES2 },
>     { "GL_OES_stencil_wrap",                        o(EXT_stencil_wrap),                             ES1       },
>     /* GL_OES_texture_3D is disabled due to missing GLSL support. */
>     { "GL_OES_texture_3D",                          o(EXT_texture3D),                           0              },

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0srkUACgkQX1gOwKyEAw/tzwCfUJ5JfJpS2vMqVluKT2VOggZD
QnoAoJY8vnREzWJ7NuQar4ZG4OVZGGfV
=1GsS
-----END PGP SIGNATURE-----