[Mesa-dev] [PATCH 2/3] intel: Fix height in stencil buffer region allocation

Chad Versace chad at chad-versace.us
Sat Jul 9 09:01:07 PDT 2011


If the height of the stencil buffer were odd, then we allocated a region
whose height was too small --- `height / 2` rather than
`height / 2 + height % 2`.

On gen5 with intel_screen.hw_must_use_separate_stencil enabled,
Fixes-Piglit-test: fbo-stencil-*

Note: This is a candidate for the 7.11 branch
Signed-off-by: Chad Versace <chad at chad-versace.us>
---
 src/mesa/drivers/dri/intel/intel_fbo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c
index 90c3909..5ea83cf 100644
--- a/src/mesa/drivers/dri/intel/intel_fbo.c
+++ b/src/mesa/drivers/dri/intel/intel_fbo.c
@@ -196,7 +196,7 @@ intel_alloc_renderbuffer_storage(struct gl_context * ctx, struct gl_renderbuffer
 				       I915_TILING_Y,
 				       cpp * 2,
 				       width,
-				       height / 2,
+				       height / 2 + height % 2,
 				       GL_TRUE);
       if (!irb->region)
 	return false;
-- 
1.7.5.4



More information about the mesa-dev mailing list