[Mesa-dev] [PATCH 13/13] glsl: Compare vector indices in blocks

Eric Anholt eric at anholt.net
Fri Jul 22 18:12:41 PDT 2011

On Fri, 22 Jul 2011 15:20:03 -0700, Ian Romanick <idr at freedesktop.org> wrote:
> I'd like to refactor that code to be more like the non-constant array
> index lowering pass.  The r-value and l-value case only differ in the
> order of the operands in the generated assignments and the optional
> if-statement wrapping.  It really should be unified.
> My inclination is to convert the one missed base_ir->insert_before to a
> list.push_tail.  Does that see alright, or would you prefer it the other
> way?

Works for me.  It was the inconsistency that bugged me :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110722/67064176/attachment.pgp>

More information about the mesa-dev mailing list