[Mesa-dev] [PATCH v3] i965: Check actual tile offsets in Gen4 miptree workaround.

Eric Anholt eric at anholt.net
Thu Jul 28 11:19:25 PDT 2011

On Wed, 27 Jul 2011 16:58:41 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> The purpose of the (irb->draw_offset & 4095) != 0 check was to ensure
> that we don't have XYy offsets into a tile, since Gen4 hardware doesn't
> support that.  However, it's insufficient: there are cases where
> draw_offset & 4095 is 0 but we still have a Y-offset.  This leads to an
> assertion failure in brw_update_renderbuffer_surface with tile_y != 0.
> Instead, simply call intel_renderbuffer_tile_offsets to compute the
> actual X/Y offsets and check if either are non-zero.  This makes both
> the workaround and the assertion check the same things.
> Fixes piglit test fbo-generatemipmap-formats, and should also fix
> bugs #34009 and #39487.

Looks good to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110728/09eb072e/attachment.pgp>

More information about the mesa-dev mailing list