[Mesa-dev] [PATCH 2/2] glx: Remove (unused, broken) fastImageUnpack fast path

[Adam Jackson]

On Thu, 2011-06-02 at 09:19 -0600, Brian Paul wrote:
> On 06/01/2011 11:44 AM, Adam Jackson wrote:
> > -      /* Apply pixel store unpack modes to copy data into buf */
> > -      if (src != NULL) {
> > -         (*gc->fillImage) (gc, dim, width, height, depth, format, type,
> > -                           src, buf, modes);
> > -      }
> > -      else {
> > -         if (dim<  3) {
> > -            (void) memcpy(modes, __glXDefaultPixelStore + 4, 20);
> > -         }
> > -         else {
> > -            (void) memcpy(modes, __glXDefaultPixelStore + 0, 36);
> > -         }
> > -      }
> > +    /* Apply pixel store unpack modes to copy data into buf */
> > +    if (src != NULL) {
> > +	(*gc->fillImage) (gc, dim, width, height, depth, format, type,
> > +			  src, buf, modes);
> > +    }
> > +    else {
> > +	if (dim<  3) {
> > +	    (void) memcpy(modes, __glXDefaultPixelStore + 4, 20);
> 
> Independent of this patch, __glXDefaultPixelStore + 4 seems like a 
> magic number kind of thing.  There's macros for this value and others 
> in indirect.c (grep default_pixel_store_2D) which should probably be 
> used here.  Feel like taking care of that?

Sure, I have some other cleanups I want to do that will require touching
the generated files (and the generators) anyway.

> Reviewed-by: Brian Paul <brianp at vmware.com>

Thanks, pushed.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110602/81bf4778/attachment.pgp>