[Mesa-dev] [PATCH 2/2] intel: Define span functions for S8 renderbuffers

[Chad Versace]

On 06/03/2011 03:36 PM, Kenneth Graunke wrote:
> On 06/03/2011 12:47 PM, Chad Versace wrote:
>> Since the stencil buffer is interleaved, the generic Mesa renderbuffer
>> accessors do not suffice. Custom span functions are necessary.
>>
>> Signed-off-by: Chad Versace<chad at chad-versace.us>
> 
> I know you had done this with handwritten functions at one point, rather than using stenciltmp.h.  Why the change, if you don't
> mind me asking? Either way is fine, of course.

Before finalizing the patch, I decided to thoroughly inspect the macros-from-hell one more time, just to make sure that I didn't
miss some necessary magic they did. And, I did miss some magic. The macros perform clipping on the span ranges.

Rather than try to duplicate (likely incorrectly) the macros' clipping logic, I just bit the bullet and used them.

> I haven't verified your math but I know that it's necessary and that you've tested it.
> 
> Acked-by: Kenneth Graunke <kenneth at whitecape.org>


-- 
Chad Versace
chad at chad-versace.us