[Mesa-dev] Status of VDPAU and XvMC state-trackers (was Re: Build error on current xvmc-r600 pipe-video)

[Jose Fonseca]

I think we need to have a proper review round of the gallium interfaces, so that we have an interface everybody feels that we can support going forward, which did not happen last round.

That said, I don't think much attention has been given to this branch outside from those working on it. So those with constructive feedback should say now, or "forever hold your peace". Because one way or the other, it doesn't make sense to have useful code on a branch.

Attached is the diff between pipe-video and master for src/gallium/include/*

I need to look more closely at this, but I can't help thinking that the new interfaces are quite different from the rest of gallium's 3d interfaces. Instead of being an extension to gallium 3D interfaces/objects, pipe-video seems more like a completely parallel set of interfaces/objects.

- AFACIT all drivers implement pipe_video context using vl_create_context(pipe_context *). If so then it makes no sense for this to be a gallium interface. It should all be state tracker code.

At very least there are ovious things that need to be fixed:

- get_param / is_format_supported should not be duplicated from screen.
- #if 0 ... #endif code in the interface headers

I'd also would like to see how generic these interfaces are (e.g. could we use this to implement DXVA DDI).

Jose

----- Original Message -----
> Am Samstag, den 04.06.2011, 15:20 -0400 schrieb Matt Turner:
> > Is there a reason that this can't be merged to master?
> Since float buffer support was merged to master I can't see any more
> obstacles. Just gone over the branch one more time and fixed some
> problem created by merging.
> 
> > It seems like the longer it remains as a branch, the more mess
> > there
> > is going to be from merging master into pipe-video over and over
> > again.
> Merging with master is actually quite simple most of the time, but I
> haven't tried the other way around jet.
> 
> > It won't hurt anyone to have it in master, so I think you should
> > just
> > go ahead and merge it.
> Ok, If nobody objects till tomorrow evening I going to push it to
> master.
> 
> > I also don't think it's too late to wipe out the "Merge
> > remote-tracking branch 'mareko/r300g-draw-instanced' into
> > pipe-video"
> > and subsequent revert from git. No one is basing their work on your
> > branch.
> Already reverted it.
> 
> Thanks,
> Christian.
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pipe-video.diff
Type: text/x-patch
Size: 19468 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110604/c8856ea0/attachment-0001.bin>