[Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz
Chad Versace
chad at chad-versace.us
Sun Jun 5 20:48:17 PDT 2011
On Sun, 5 Jun 2011 11:01:21 +0200, Nicolas Kaiser <nikai at nikai.net> wrote:
> Just noticed two typos in comments.
>
> * Chad Versace <chad at chad-versace.us>:
> > --- a/src/mesa/drivers/dri/intel/intel_context.c
> > +++ b/src/mesa/drivers/dri/intel/intel_context.c
> (..)
> > +/**
> > + * \brief Verify that the X driver supports hiz and separate stencil.
> > + *
> > + * This implements the cleanup stage of the handshake described in the
> > + * comments for 'enum intel_dri2_has_hiz'.
> > + *
> > + * This should be called from intel_update_renderbuffers() after 1) the
> > + * DRIdrawable has been queried for its buffers via DRI2GetBuffersWithFormat()
> > + * and 2) the DRM region of each returned DRIbuffer has been assigned to the
> > + * appropriate intel_renderbuffer. Futhermore, this should be called *only*
>
> Furthermore
>
> (..)
> > + /*
> > + * I don't know how to recover from the failure assertion below.
> > + * Rather than fail gradually and unexpectedtly, we should just die
>
> unexpectedly
>
>
> Best regards,
> Nicolas Kaiser
Thanks. Spelling fixes applied.
More information about the mesa-dev
mailing list