[Mesa-dev] [PATCH 0/6] Per driver pci id lists

Alex Deucher alexdeucher at gmail.com
Mon Jun 6 11:55:29 PDT 2011


On Mon, Jun 6, 2011 at 2:38 PM, Benjamin Franzke
<benjaminfranzke at googlemail.com> wrote:
> 2011/6/6 Alex Deucher <alexdeucher at gmail.com>:
>> Looks good.  Thanks.  Overall the patch set looks fine to me.  I agree
>> with Marek that it might be better to put the pci ids together
>> somewhere.  For the series:
>>
>> Reviewed-by: Alex Deucher <alexdeucher at gmail.com>
>
> Ok, moved the lists into include/pci_ids/, hope thats ok.
>
> Updated patch series is available at:
> http://cgit.freedesktop.org/~bnf/mesa/log/?h=pciids-2
>

Sorry, I just thought of one tricky situation.  Only r600g supports
CAYMAN asics, so r600c shouldn't have the CAYMAN pci ids.  Maybe just
split the CAYMAN ids out into a new header, cayman_pci_ids.h, and
include both r600_pci_ids.h and cayman_pci_ids.h in r600g and only
r600_pci_ids.h in r600c.

Alex


More information about the mesa-dev mailing list