No subject


Wed Jun 8 07:12:48 PDT 2011


<div class=3D"im"><br>
+ =C2=A0 if (x &lt;=3D 1)<br>
+ =C2=A0 =C2=A0 =C2=A0 return 1;<br>
<br>
<br>
</div>I think it would make more sense to move this above the #ifdef and no=
t<br>
duplicate it in each implementation. It&#39;s about the function input, not=
<br>
the implementations.<br></blockquote><div>I thought to that, but given that=
 declaration must be before the code,<br>in the &quot;gcc path&quot; you wi=
ll have the declaration of &quot;val&quot; which is not used...<br>you will=
 have a GCC warning.<br>
Moreover, I think doing this <span class=3D"clickable">slightly</span> redu=
ces the code readibility<br>(the two &quot;path&quot; would be imbricated).=
<br>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt =
0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

<br>


More information about the mesa-dev mailing list