[Mesa-dev] [PATCH] faster logbase2() - again

Benjamin Bellec b.bellec at gmail.com
Wed Jun 8 13:24:41 PDT 2011


Le 08/06/2011 22:08, Roland Scheidegger a écrit :
> Looks good to me - but skip the special n <= 1 case that's what the
> (n|1) input to the __builtin_clz is good for.
Ok, I'm not familiar with bit manipulation in fact...

> Oh and I didn't notice before but there's an error in the gcc version
> check (as that's defined as (__GNUC__ * 100 + __GNUC_MINOR__) - we're
> ignoring patchlevel). Though as said there's the popcount usage right
> next to it which doesn't do a version check neither - if that's the only
> thing requiring gcc 3.4 we should fix that otherwise could just make gcc
> 3.4 a requirement.
Ok I did'nt know that.

Here is my 3 patchs fixed. I hope this are the last of the series :-)

Benjamin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: faster-util_next_power_of_two-function-v5.patch
Type: text/x-diff
Size: 890 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110608/0edea5b1/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: faster-logbase2-gallium-v2.patch
Type: text/x-diff
Size: 654 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110608/0edea5b1/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: faster-logbase2-mesa-v2.patch
Type: text/x-diff
Size: 584 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110608/0edea5b1/attachment-0002.patch>


More information about the mesa-dev mailing list