[Mesa-dev] [PATCH] st/mesa: improved is_interleaved_arrays() checking

Brian Paul brianp at vmware.com
Tue Jun 14 08:39:41 PDT 2011


Good question.  I was thinking that the interleaved vs. 
non-interleaved paths could probably be merged with a little work.  I 
don't remember the original reason for doing things as they are.

-Brian


On 06/14/2011 08:55 AM, Jose Fonseca wrote:
> Looks good Brian.
>
> BTW, does detecting interleaved arrays still provide any advantage for current HW drivers?
>
> Jose
>
> ----- Original Message -----
>> Check that the difference in array pointers/offsets from the 0th
>> array are less than the stride, for both VBOs and user-space arrays.
>> Previously, we were only doing this for the later.
>>
>> This tightens up the interleaved array test and fixes a problem with
>> the llvmpipe driver where we were creating way too many vertex fetch
>> variants only because the pipe_vertex_element::src_offset values were
>> changing frequently.  This change results in a 5x speed-up for one of
>> the viewperf tests.
>>
>> Also, clean up the function to make it easier to understand.




More information about the mesa-dev mailing list