[Mesa-dev] [PATCH] intel: Fix region refcounting in intel_alloc_renderbuffer_storage

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 15 16:06:11 PDT 2011


On Wed, 15 Jun 2011 15:54:13 -0700, Chad Versace <chad at chad-versace.us> wrote:
> Replace instances of
>     irb->region = region
> with
>     intel_region_reference(&irb->region, region)

The comment is slightly misleading, as you are performing a replacement
of
  irb->region = intel_region_alloc();
with
  struct intel_region *region = intel_region_alloc();
  intel_region_reference(&irb->region, region);

I'm curious, what's the advantage? i.e. what am I not understanding that 
needs to be explained in the changelog?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the mesa-dev mailing list