[Mesa-dev] [PATCH] st/xorg: fix crash triggered by rendercheck -t composite -f a8r8g8b8 -o Src, Saturate

Marcin Slusarz marcin.slusarz at gmail.com
Sun Jun 19 15:02:22 PDT 2011


On Mon, May 16, 2011 at 09:52:47PM +0200, Marcin Slusarz wrote:
> samplers[0] may remain uninititialized if src picture/pixmap is null
> ---
>  src/gallium/state_trackers/xorg/xorg_composite.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/gallium/state_trackers/xorg/xorg_composite.c b/src/gallium/state_trackers/xorg/xorg_composite.c
> index 9fdbc90..eca3bbf 100644
> --- a/src/gallium/state_trackers/xorg/xorg_composite.c
> +++ b/src/gallium/state_trackers/xorg/xorg_composite.c
> @@ -389,7 +389,7 @@ bind_samplers(struct exa_context *exa, int op,
>                struct exa_pixmap_priv *pMask,
>                struct exa_pixmap_priv *pDst)
>  {
> -   struct pipe_sampler_state *samplers[PIPE_MAX_SAMPLERS];
> +   struct pipe_sampler_state *samplers[PIPE_MAX_SAMPLERS] = {0};
>     struct pipe_sampler_state src_sampler, mask_sampler;
>     struct pipe_sampler_view view_templ;
>     struct pipe_sampler_view *src_view;
> -- 

Can someone commit this patch?
 
Marcin



More information about the mesa-dev mailing list