[Mesa-dev] [PATCH 3/4] i965: Don't bother telling swrast_setup about state updates until fallback.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/22/2011 11:53 AM, Eric Anholt wrote:
> On Wed, 22 Jun 2011 10:59:37 -0700, Ian Romanick <idr at freedesktop.org> wrote:
>>> diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c
>>> index 8b95444..70aee52 100644
>>> --- a/src/mesa/drivers/dri/intel/intel_context.c
>>> +++ b/src/mesa/drivers/dri/intel/intel_context.c
>>> @@ -504,7 +504,6 @@ intelInvalidateState(struct gl_context * ctx, GLuint new_state)
>>>      struct intel_context *intel = intel_context(ctx);
>>>  
>>>     _swrast_InvalidateState(ctx, new_state);
>>
>> Should this also get moved?  I guess I'm not sure what these two
>> functions do, so this may be a spurious comment.
> 
> swrast has some internal stuff to mitigate the statechange overhead (if
> you haven't swrasted in a while, it replaces its function pointer with a
> stub, and when you go to use it it notices that it's been stubbed out
> and assumes all state has changed).  Because of that,
> swrast_InvalidateState ended up being <.1% CPU usage.  It's tempting to
> move it out even still, but I think if we do then we'd need to
> _swrast_Wakeup anywhere that we call into swrast.

That makes sense.

For the series:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk4CO8gACgkQX1gOwKyEAw+ZOQCeLR7GTmwNB8JaSq8Tz0AgB3U7
gjgAn07vHoNq/Yc99brndnwSp+aa0BIj
=E2KO
-----END PGP SIGNATURE-----