[Mesa-dev] [PATCH] configure.ac: Make --without-gallium-drivers work as expected

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/22/2011 12:55 PM, Dan Nicholson wrote:
> On Wed, Jun 22, 2011 at 11:38 AM, Ian Romanick <idr at freedesktop.org> wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> ---
>>  configure.ac |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index c9dd8a7..76736c0 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -562,6 +562,12 @@ AC_ARG_WITH([gallium-drivers],
>>     [with_gallium_drivers="$withval"],
>>     [with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT"])
>>
>> +# Doing '--without-gallium-drivers' will set this variable to 'no'.  Clear it
>> +# here so that the script doesn't choke on an unknown driver name later.
>> +if test "x$with_gallium_drivers" = "xno"; then
>> +   with_gallium_drivers=''
>> +fi
> 
> Nitpicky, but the other thing that would be nice is if bare
> --with-gallium-drivers becomes $GALLIUM_DRIVERS_DEFAULT. Could be:
> 
> case "$with_gallium_drivers" in
> yes) with_gallium_drivers="$GALLIUM_DRIVERS_DEFAULT" ;;
> no) with_gallium_drivers='' ;;
> esac
> 
> Either way, good to catch this case.

I like that better.

> Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>

When I take your change, I'll make this S-o-b, okay?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk4CT34ACgkQX1gOwKyEAw+YIgCcCx5q6ZQtxb9ZiDJqQlCG8BxT
ZJ4An1XQHar9yFL6kNk8NGdDbLYpN6wM
=TXc0
-----END PGP SIGNATURE-----