[Mesa-dev] [PATCH 3/5] glsl: Create AST structs corresponding to new productions in grammar

Kenneth Graunke kenneth at whitecape.org
Tue Jun 28 22:47:49 PDT 2011


On 06/28/2011 02:48 PM, Dan McCabe wrote:
> Previously we added productions for:
> 	switch_body
> 	case_label_list
> 	case_statement
> 	case_statement_list
> Now add AST structs corresponding to those productions.

Both 1/3 and 3/3 look good.  You might actually want to squash
them...they're so similar.  I'd order them like this:

[PATCH 1/4] glsl: Add productions to GLSL grammar for switch statements
[PATCH 2/4] glsl: Create AST structures for switch statements
[PATCH 3/4] glsl: Reference data structure ctors in grammar
[PATCH 4/4] glsl: Generate IR for switch statements


More information about the mesa-dev mailing list