[Mesa-dev] Mesa (master): i915g: Improve SIN/COS a bit.

[Brian Paul]

On Wed, Jun 29, 2011 at 5:49 AM, Jon TURNEY <jon.turney at dronecode.org.uk> wrote:
>> Module: Mesa
>> Branch: master
>> Commit: 062a1e291fdc0ef69b6677f8ae0e3471047e281d
>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=062a1e291fdc0ef69b6677f8ae0e3471047e281d
>>
>> Author: Stéphane Marchesin <marcheu at chromium.org>
>> Date:   Tue Jun 28 00:53:01 2011 -0700
>>
>> i915g: Improve SIN/COS a bit.
>>
>> ---
>>
>>  src/gallium/drivers/i915/i915_fpc_translate.c |   40 ++++++++++++------------
>>  1 files changed, 20 insertions(+), 20 deletions(-)
>
> This adds some more uses of M_PI to i915_fpc_translate.c, before the
> definition of M_PI it makes for the benefit of <math.h> which don't define
> M_PI. See [1].
>
> Attached is a patch which fixes this by moving the definition of M_PI.

Reviewed-by: Brian Paul <brianp at vmware.com>


> I'm not sure why this file and the few others which do this, don't include
> compiler.h for the definition M_PI there...

We can't include Mesa's compiler.h in any of the gallium sources.  We
should probably define M_PI in one of the gallium utility headers.

-Brian