[Mesa-dev] [PATCH 1/2] mesa: invalidate framebuffer if internal format of renderbuffer is changed

Brian Paul brianp at vmware.com
Mon Mar 7 14:02:17 PST 2011


Looks good.

-Brian

On 03/07/2011 12:01 PM, Marek Olšák wrote:
> A new patch is attached.
>
> Marek
>
> On Mon, Mar 7, 2011 at 4:16 PM, Brian Paul <brianp at vmware.com
> <mailto:brianp at vmware.com>> wrote:
>
>     On 03/05/2011 09:26 PM, Marek Olšák wrote:
>
>         RenderTexture doesn't have to be called in invalidate_rb, I guess.
>         ---
>
>
>     The patch looks good but there's one simple optimization that could
>     be made.  If glRenderBufferStorage() is called with a new
>     width/height but the internalFormat stays the same, we wouldn't have
>     to invalidate the parent FBO(s).
>
>     I think changing the size of a renderbuffer would be more common
>     than channging its format.
>
>     -Brian
>
>



More information about the mesa-dev mailing list