[Mesa-dev] [PATCH 0/3] Removing unnecessary flushes in Gallium

Marek Olšák maraeo at gmail.com
Thu Mar 10 11:25:34 PST 2011


I have reviewed where we call flush() and why and some of them
seem unnecessary to me. Those flushes may slightly decrease
performance, depending on each driver, and may hide driver bugs.

glFlush doesn't have to be called in OpenGL so often, and
I think state trackers should follow suit.

The worst example of this is st/vega. I guess those flushes are
there for debugging only.

Please review.

Marek Olšák (3):
      st/mesa: remove unnecessary flushes
      st/vega: remove unnecessary flushes
      draw: remove unnecessary flush

 src/gallium/auxiliary/draw/draw_pipe_pstipple.c |    7 -------
 src/gallium/auxiliary/util/u_gen_mipmap.c       |    2 --
 src/gallium/state_trackers/vega/api_images.c    |    4 ----
 src/gallium/state_trackers/vega/image.c         |    8 --------
 src/gallium/state_trackers/vega/mask.c          |    2 --
 src/mesa/state_tracker/st_cb_fbo.c              |    3 ---
 6 files changed, 0 insertions(+), 26 deletions(-)


More information about the mesa-dev mailing list