[Mesa-dev] [PATCH 08/11] i965/fs: Fix GPU hang on texture2d-bias on pre-Ironlake.

Kenneth Graunke kenneth at whitecape.org
Fri May 13 16:47:56 PDT 2011

On 05/12/2011 09:05 PM, Eric Anholt wrote:
> In the 16-wide rework, I missed that we were setting some things to be
> SIMD16 mode (corresponding to their setup in emit_texture_gen4()).
> ---
>   src/mesa/drivers/dri/i965/brw_fs.cpp |   10 ++++++----
>   1 files changed, 6 insertions(+), 4 deletions(-)

Er...right.  Tricky.  I had to remind myself that brw_fs never tries to 
emit 16-wide programs on Gen4 (otherwise the SIMD8 cases would need to 
set simd_mode back to 8).

I might suggest adding this near the top:
assert(intel->gen >= 5 || c->dispatch_width == 8);

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

More information about the mesa-dev mailing list