[Mesa-dev] [PATCH 08/11] i965/fs: Fix GPU hang on texture2d-bias on pre-Ironlake.

[Eric Anholt]

On Fri, 13 May 2011 16:47:56 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 05/12/2011 09:05 PM, Eric Anholt wrote:
> > In the 16-wide rework, I missed that we were setting some things to be
> > SIMD16 mode (corresponding to their setup in emit_texture_gen4()).
> > ---
> >   src/mesa/drivers/dri/i965/brw_fs.cpp |   10 ++++++----
> >   1 files changed, 6 insertions(+), 4 deletions(-)
> 
> Er...right.  Tricky.  I had to remind myself that brw_fs never tries to 
> emit 16-wide programs on Gen4 (otherwise the SIMD8 cases would need to 
> set simd_mode back to 8).
> 
> I might suggest adding this near the top:
> assert(intel->gen >= 5 || c->dispatch_width == 8);

Good call, I'd have easily forgotten that pain if I was enabling simd16
pre-gen5.  Moved that assert down to the gen < 5 branch, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110514/7fb2bb61/attachment.pgp>