[Mesa-dev] [PATCH] mesa: Fix return type of _mesa_get_format_bytes() (#37351)

Adam Jackson ajax at redhat.com
Mon May 23 08:00:19 PDT 2011

On 5/20/11 8:50 PM, Jose Fonseca wrote:

>> I don't care which approach we go with.  This will likely fix it
>> everywhere, but I'd like there to be a comment explaining why the
>> return
>> type must not be unsigned.  Otherwise someone will come along in the
>> future and make it unsigned in the name of "code cleanup."
> I agree with Ian: Adam's patch is good, but a comment would be useful, as the implicit coercion to unsigned is both unfortunate and unintuitive.

Makes sense.  Added a comment above _mesa_get_format_bytes and pushed, 

- ajax

More information about the mesa-dev mailing list